Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add continuous deployment to Dash server #12

Merged
merged 3 commits into from
Jun 21, 2023
Merged

Add continuous deployment to Dash server #12

merged 3 commits into from
Jun 21, 2023

Conversation

tamidodo
Copy link
Contributor

I've passed along the required secrets to the ALS team to add to the github repo, otherwise should be good to go. I've added a new user for LBL to access our services server and given that user access to the "prod" environment of our prototype app.

@tamidodo tamidodo requested a review from hannahker June 21, 2023 16:33
Copy link
Collaborator

@hannahker hannahker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Just see flake8 comment. Can you also add in the missing Procfile for a DE deploy?

- name: Lint with flake8
run: |
# stop the build if there are Python syntax errors or undefined names
flake8 pages app.py utils index.py predeploy_update_data.py tasks.py --count --select=E9,F63,F7,F82 --show-source --statistics
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can remove these specific files and just run flake8 against all python files in the repo

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oops yup

@tamidodo tamidodo requested a review from hannahker June 21, 2023 19:08
Copy link
Collaborator

@hannahker hannahker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! 💃

@tamidodo tamidodo merged commit 667679a into main Jun 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants